]> Kevux Git Server - fll/commit
Revert: Partially revert unsigned to signed change in "Bugfix: Compilation/Portabilit...
authorKevin Day <thekevinday@gmail.com>
Sat, 29 May 2021 23:12:21 +0000 (18:12 -0500)
committerKevin Day <thekevinday@gmail.com>
Sat, 29 May 2021 23:12:34 +0000 (18:12 -0500)
commit67cc9120d3e27fdbda0f7bd7464de9ee3805c964
tree192342ca4d148d1da462c0b0f5e39b2d2885d3fd
parenta89cb6c0625eaa81770b27ce245adc1a40c9f71e
Revert: Partially revert unsigned to signed change in "Bugfix: Compilation/Portability problems exposed when building against musl-libc.".

There were problems with the console parameter size, so switching that to signed seems fine.
However, switching the more general standard approach from unsigned to signed is more dangerous.
Signed operations are much more fickle when overflowing or when using bitwise operations.
In fact, the C standards leave a lot of this behavior as undefined.

Much of the logic used in operating and manipulating array lengths (as counters or with bitwise operations such as << or >>) is affected by the previous change from signed to unsigned.
Avoid these signed problems by reverting this behavario.
The console parameter length will remain as a signed.

see: 7199b83b9596855a9929d12e5942cc541c194b5f
level_0/f_type/c/type.h