]> Kevux Git Server - fll/commit
Cleanup: Rename f_account functions in attempt to be easier to read.
authorKevin Day <thekevinday@gmail.com>
Sun, 16 Jan 2022 21:15:09 +0000 (15:15 -0600)
committerKevin Day <thekevinday@gmail.com>
Sun, 16 Jan 2022 21:15:09 +0000 (15:15 -0600)
commit80b45dcc28aeba462ee3f87727bbb1d9c426acb5
treea73cccbaf1ef5ef1c4988a06a7f294a8aca712a0
parenteaffa36f00cdb340a84c0847c22aab6248814903
Cleanup: Rename f_account functions in attempt to be easier to read.

I originally tried to group the logic by "name" and "id".
This becomes confusing when there is "group name" and "user name" or "group id" and "user id".
The function name with the structure "f_account_id_group_by_name" is intended to be understood as get id of group by name for account.
However, because account is in front (part of f_account) it could be easily misread as get account id by name with some spurious "group" injected.
This is clearly a bad interpretation but that interpretation is easy to think of.

Drop "user" because "account" and "user" should be synonymous.
Move "group" to the left in all cases to designate that this is about "group" associated with account.
Now f_account_group_id_by_name sounds more like get id of group by name for account.
17 files changed:
level_0/f_account/c/account.c
level_0/f_account/c/account.h
level_0/f_account/data/build/settings-tests
level_0/f_account/tests/c/test-account-group_id_by_name.c [moved from level_0/f_account/tests/c/test-account-id_group_by_name.c with 77% similarity]
level_0/f_account/tests/c/test-account-group_id_by_name.h [moved from level_0/f_account/tests/c/test-account-id_group_by_name.h with 59% similarity]
level_0/f_account/tests/c/test-account-group_name_by_id.c [moved from level_0/f_account/tests/c/test-account-name_group_by_id.c with 78% similarity]
level_0/f_account/tests/c/test-account-group_name_by_id.h [moved from level_0/f_account/tests/c/test-account-name_group_by_id.h with 59% similarity]
level_0/f_account/tests/c/test-account-id_by_name.c [moved from level_0/f_account/tests/c/test-account-id_user_by_name.c with 75% similarity]
level_0/f_account/tests/c/test-account-id_by_name.h [moved from level_0/f_account/tests/c/test-account-id_user_by_name.h with 56% similarity]
level_0/f_account/tests/c/test-account-name_by_id.c [moved from level_0/f_account/tests/c/test-account-name_user_by_id.c with 78% similarity]
level_0/f_account/tests/c/test-account-name_by_id.h [moved from level_0/f_account/tests/c/test-account-name_user_by_id.h with 56% similarity]
level_0/f_account/tests/c/test-account.c
level_0/f_account/tests/c/test-account.h
level_3/controller/c/controller/private-controller.c
level_3/controller/c/controller/private-controller.h
level_3/controller/c/rule/private-rule.c
level_3/fake/c/private-make.c