]> Kevux Git Server - fll/commit
Bugfix: Invalid comment handling in FSS Embedded Read.
authorKevin Day <Kevin@kevux.org>
Sun, 25 Aug 2024 04:30:44 +0000 (23:30 -0500)
committerKevin Day <Kevin@kevux.org>
Sun, 25 Aug 2024 04:41:39 +0000 (23:41 -0500)
commit93994704ebceb74b7a712166bbe757821ed007db
treef490f3aa9a0901f90db3ab49fe6a3ecfee320744
parentf5a4325d91d29682de4c47af54df09a210b3cf87
Bugfix: Invalid comment handling in FSS Embedded Read.

The comments are not being properly processed because graph_first is not and should be being set to 0x1 at start.
As a result, the first comment is not being treated as a comment.

Make sure to reset the `graph_first` and `line_start` after processing the comment.
The comment starts at the line and so use `line_start` rather than `newline_last + 1`.
Remove dead code where `graph_first == 0x2` is being checked inside a block that requires `graph_first` to be `0x1`.

Update code comments about `graph_first` in several of the fl_fss read sources.

Add additional check for buffer string range when processing comments.

Update the runtime tests as appropriate.

I also noticed that several of these runtime tests use `--line` but are showing multiple lines.
I will address this bug in a separate commit.
26 files changed:
level_1/fl_fss/c/fss/basic_list.c
level_1/fl_fss/c/fss/embedded_list.c
level_1/fl_fss/c/fss/extended_list.c
level_3/fss_embedded_list_read/c/private-read.c
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-name-привет_has_space-select-0-total.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-name-привет_has_space-select-0.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-name-привет_has_space-total.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-name-привет_has_space.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-original.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-select-0-original.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-select-0.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-total.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content-trim.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-content.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-line-0.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-line-1.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-line-100.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-line-5.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-line-6.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-name-привет_has_space-select-0.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-name-привет_has_space-total.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-original.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-select-0.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-total.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content-trim.expect
level_3/fss_embedded_list_read/tests/runtime/fss_0008/expect/test-0002-mixed-object_and_content.expect