Cleanup: Fully remove stale/unused variables.

I simply assumed the compiler warnings meant that the variables were not used at all.
Looks like this is an incorrect assumption.
The compilers appear to more intelligent than I expected and can detect that even though the variables are modified later on, they still are not used.

This is good news.
The bad news is that means I have bad code resulting from an incomplete clean up that need to be fixed.
This bad code is now fixed.

diff --git a/level_3/fake/c/private-make-operate.c b/level_3/fake/c/private-make-operate.c
index a78f3639ffae4bb5c98c8ad3312f4274d75afa58..40c7c9fcafb3f8e0e4eeb63e82bfb80bf47ac6df 100644 (file)
--- a/level_3/fake/c/private-make-operate.c
+++ b/level_3/fake/c/private-make-operate.c
@@ -74,8 +74,6 @@ extern "C" {
 
     data_make.path.stack.used = 1;
 
-    macro_f_mode_t_set_default_umask(mode, data->main->umask);
-
     fake_make_load_parameters(&data_make, &status);
 
     fake_make_load_fakefile(&data_make, &status);

diff --git a/level_3/fake/c/private-make-operate_validate.c b/level_3/fake/c/private-make-operate_validate.c
index 14c57f393312562ade14e1ba81c98a030182e13e..773e65a42dfd79bd27398053aea62d6774323474 100644 (file)
--- a/level_3/fake/c/private-make-operate_validate.c
+++ b/level_3/fake/c/private-make-operate_validate.c
@@ -1021,7 +1021,6 @@ extern "C" {
                 }
                 else if (arguments.array[i].string[0] == f_string_ascii_minus_s.string[0]) {
                   range.start = 1;
-                  is_negative = F_true;
                 }
 
                 if (range.start > range.stop) {