]> Kevux Git Server - fll/commitdiff
Bugfix: FSS Extended List object detection is invalid.
authorKevin Day <thekevinday@gmail.com>
Wed, 28 Oct 2020 02:50:53 +0000 (21:50 -0500)
committerKevin Day <thekevinday@gmail.com>
Wed, 28 Oct 2020 02:50:53 +0000 (21:50 -0500)
Not sure how I let this one slip through.
The code is checking for an EOL if found checks to see if that EOL is a graph...which is never the case.

What I meant to do is more likely breaking on EOL or breaking on graph.

level_1/fl_fss/c/fss_extended_list.c

index 1892f9347fda283f915da3165375df1e49157310..67437848f3f2334f4c3d11c1798f879f052f363b 100644 (file)
@@ -106,12 +106,12 @@ extern "C" {
 
           while (range->start <= range->stop && range->start < buffer->used) {
 
-            if (buffer->string[range->start] == f_fss_eol) {
-              status = f_fss_is_graph(*buffer, *range);
-              if (F_status_is_error(status)) break;
+            if (buffer->string[range->start] == f_fss_eol) break;
 
-              if (status == F_true) break;
-            }
+            status = f_fss_is_graph(*buffer, *range);
+            if (F_status_is_error(status)) break;
+
+            if (status == F_true) break;
 
             status = f_utf_buffer_increment(*buffer, range, 1);
             if (F_status_is_error(status)) break;