]> Kevux Git Server - fll/commitdiff
Update: Add comment in Featureless Make code to designate changes the must be done.
authorKevin Day <kevin@kevux.org>
Sat, 5 Aug 2023 20:57:14 +0000 (15:57 -0500)
committerKevin Day <kevin@kevux.org>
Sat, 5 Aug 2023 20:57:14 +0000 (15:57 -0500)
The use of main->program.parameters.arguments should no longer happen.
This is the old behavior and it looks like it has not been completely migrated.

This is wrong an can even have invalid read sizes.

level_3/fake/c/main/fake.c

index 9374aceb314382e654fcb0f34cee904ffa7f4647..7cd4659c21df58649fe5df61705a580479fa0557 100644 (file)
@@ -456,6 +456,7 @@ extern "C" {
       if (parameter->result & f_console_result_value_e) {
         const f_number_unsigned_t index = parameter->values.array[parameter->location];
 
+        // @fixme these should not be accessing main->program.parameters.arguments directly and should instead use setting flags.
         if (f_path_is_absolute(main->program.parameters.arguments.array[index]) == F_true || f_path_is_relative_current(main->program.parameters.arguments.array[index]) == F_true) {
           requireds[1] = F_none; // fake_long_data_s
         }