Bugfix: the trait t_base_return_message get_message() returns incorrect variable

The message is being stored in the variable $message, not $value.

diff --git a/common/base/classes/base_return.php b/common/base/classes/base_return.php
index 2e5294807774a2c4452f6a2dcdca8b225c45e109..4801c93f6d9bd84003b2554e848c671ae2bb106d 100644 (file)
--- a/common/base/classes/base_return.php
+++ b/common/base/classes/base_return.php
@@ -216,13 +216,18 @@ trait t_base_return_message {
   }
 
   /**
-   * Return the value.
+   * Return the message.
    *
-   * @return $value
-   *   This can be anything that is to be considered a return value.
+   * @return string
+   *   A message string is returned.
+   *   If no message is assigned, an empty string is returned.
    */
   public function get_message() {
-    return $this->value;
+    if (is_string($this->message)) {
+      return $this->message;
+    }
+
+    return '';
   }
 }