Security: Add missing NULL at the end of string.

I was seeing "-Wno-missing-bracess" and "-Wno-logical-op-parenthese".
This looks exactly like invalid sizes.
I could not find the code that misplaces the NULL but in the process I found a different place where a NULL is in fact missing.
This adds the missing NULL.
I guess if one looks hard enough, then they will find what they are looking for.

It turns out that my original problem is actually two typos in a configuration file.

diff --git a/level_3/fake/c/private-build.c b/level_3/fake/c/private-build.c
index 422003f4d0b7561357078b32182ec06f746ecca2..a4887f2c7c55f42a0a3b2ee6a1e8ee1dc702e99c 100644 (file)
--- a/level_3/fake/c/private-build.c
+++ b/level_3/fake/c/private-build.c
@@ -32,6 +32,7 @@ extern "C" {
       f_array_length_t build_libraries_length = fake_build_parameter_library_link_path_s.used + data->path_build_libraries_shared.used;
 
       f_char_t build_libraries[build_libraries_length + 1];
+      build_libraries[build_libraries_length] = 0;
 
       memcpy(build_libraries, fake_build_parameter_library_link_path_s.string, sizeof(f_char_t) * fake_build_parameter_library_link_path_s.used);
 
@@ -42,11 +43,10 @@ extern "C" {
         memcpy(build_libraries + fake_build_parameter_library_link_path_s.used, data->path_build_libraries_static.string, sizeof(f_char_t) * data->path_build_libraries_static.used);
       }
 
-      build_libraries[build_libraries_length] = 0;
-
       f_array_length_t build_includes_length = fake_build_parameter_library_include_s.used + data->path_build_includes.used;
 
       f_char_t build_includes[build_includes_length + 1];
+      build_includes[build_includes_length] = 0;
 
       memcpy(build_includes, fake_build_parameter_library_include_s.string, sizeof(f_char_t) * fake_build_parameter_library_include_s.used);
       memcpy(build_includes + fake_build_parameter_library_include_s.used, data->path_build_includes.string, sizeof(f_char_t) * data->path_build_includes.used);

diff --git a/level_3/fss_embedded_list_read/data/build/settings b/level_3/fss_embedded_list_read/data/build/settings
index 326b6ed32158ba1e1d170b6f9dc18f0a6d5119e0..3b2f4b6a78cece98264edfb323c5530bd00a4c92 100644 (file)
--- a/level_3/fss_embedded_list_read/data/build/settings
+++ b/level_3/fss_embedded_list_read/data/build/settings
@@ -44,8 +44,8 @@ search_static yes
 #defines -D_di_libcap_ -D_di_thread_support_
 defines -D_libcap_legacy_only_ -D_pthread_attr_unsupported_ -D_pthread_sigqueue_unsupported_
 
-flags -O2 -z now -g -fdiagnostics-color=always -Wno-logical-not-parentheses -Wno-parentheses -Wno-missing-bracess
-flags-clang -Wno-logical-op-parenthese
+flags -O2 -z now -g -fdiagnostics-color=always -Wno-logical-not-parentheses -Wno-parentheses -Wno-missing-braces
+flags-clang -Wno-logical-op-parentheses
 flags-test -fstack-protector
 
 flags_library -fPIC