Update: Use copy of flag to avoid possible race conditions with controller_thread_is_...

The thread.enabled is checked multiple times in controller_thread_is_enabled() but this value may have changed.
Make a constant copy and reference that copy so that any changes after the first read will not affect the function results.

diff --git a/level_3/controller/c/thread/private-thread.c b/level_3/controller/c/thread/private-thread.c
index 3aa9c74e06b8a2d8818b221802f7366eb5139c3c..e06ee5708e4a6dab68d1717497ab44b7c599c7e4 100644 (file)
--- a/level_3/controller/c/thread/private-thread.c
+++ b/level_3/controller/c/thread/private-thread.c
@@ -172,11 +172,9 @@ extern "C" {
 #ifndef _di_controller_thread_is_enabled_
   f_status_t controller_thread_is_enabled(const bool is_normal, controller_thread_t * const thread) {
 
-    if (is_normal) {
-      return thread->enabled == controller_thread_enabled_e;
-    }
+    const bool enabled = thread->enabled;
 
-    return thread->enabled;
+    return is_normal ? enabled == controller_thread_enabled_e : enabled;
   }
 #endif // _di_controller_thread_is_enabled_