Update: Improvements exposed when writing unit tests.

Make sure to call memset on structure.
Minor style clean ups.

diff --git a/level_0/f_pipe/c/pipe.c b/level_0/f_pipe/c/pipe.c
index dba59d9b4ed81cad144a6e0f868197f887ceeba5..d74c002ca21017833171c50ca0ce0a40fc4710be 100644 (file)
--- a/level_0/f_pipe/c/pipe.c
+++ b/level_0/f_pipe/c/pipe.c
@@ -6,8 +6,11 @@ extern "C" {
 
 #ifndef _di_f_pipe_input_exists_
   f_status_t f_pipe_input_exists(void) {
+
     struct stat st_info;
 
+    memset(&st_info, 0, sizeof(struct stat));
+
     if (fstat(F_type_descriptor_input_d, &st_info) != 0) {
       return F_status_set_error(F_file_stat);
     }
@@ -22,8 +25,11 @@ extern "C" {
 
 #ifndef _di_f_pipe_warning_exists_
   f_status_t f_pipe_warning_exists(void) {
+
     struct stat st_info;
 
+    memset(&st_info, 0, sizeof(struct stat));
+
     if (fstat(F_type_descriptor_warning_d, &st_info) != 0) {
       return F_status_set_error(F_file_stat);
     }
@@ -38,8 +44,11 @@ extern "C" {
 
 #ifndef _di_f_pipe_error_exists_
   f_status_t f_pipe_error_exists(void) {
+
     struct stat st_info;
 
+    memset(&st_info, 0, sizeof(struct stat));
+
     if (fstat(F_type_descriptor_error_d, &st_info) != 0) {
       return F_status_set_error(F_file_stat);
     }
@@ -54,8 +63,11 @@ extern "C" {
 
 #ifndef _di_f_pipe_debug_exists_
   f_status_t f_pipe_debug_exists(void) {
+
     struct stat st_info;
 
+    memset(&st_info, 0, sizeof(struct stat));
+
     if (fstat(F_type_descriptor_debug_d, &st_info) != 0) {
       return F_status_set_error(F_file_stat);
     }

diff --git a/level_0/f_pipe/c/pipe.h b/level_0/f_pipe/c/pipe.h
index 21312e2e4ac6c1042100892d94274d0020230060..ca932e5546332bb2106b13480da3e4c8daacf531 100644 (file)
--- a/level_0/f_pipe/c/pipe.h
+++ b/level_0/f_pipe/c/pipe.h
@@ -14,6 +14,7 @@
 
 // Libc includes.
 #include <stdio.h>
+#include <string.h>
 #include <sys/stat.h>
 
 // FLL-0 includes.