From: Kevin Day <Kevin@kevux.org>
Date: Mon, 8 Jul 2024 03:00:09 +0000 (-0500)
Subject: Bugfix: Controller error printing function has wrong locking.
X-Git-Tag: 0.6.11~28
X-Git-Url: https://git.kevux.org/?a=commitdiff_plain;h=44c5f01264ed85f08370566326a94854bb5938fd;p=fll

Bugfix: Controller error printing function has wrong locking.

The locking being used in controller_rule_item_print_error() is based on the special case for when fll_error_print() is used.
The fll_error_print() is not being used so do not use the special case locking.
---

diff --git a/level_3/controller/c/rule/private-rule_print.c b/level_3/controller/c/rule/private-rule_print.c
index 0f6a730..af72ae4 100644
--- a/level_3/controller/c/rule/private-rule_print.c
+++ b/level_3/controller/c/rule/private-rule_print.c
@@ -66,13 +66,10 @@ extern "C" {
     if (print.verbosity == f_console_verbosity_quiet_e) return;
     if (status == F_interrupt) return;
 
-    // fll_error_print() automatically locks, so manually handle only the mutex locking and flushing rather than calling controller_lock_print().
-    f_thread_mutex_lock(&thread->lock.print);
+    controller_lock_print(print.to, thread);
 
     controller_rule_print_error_cache(print, cache, item);
 
-    flockfile(print.to.stream);
-
     controller_unlock_print_flush(print.to, thread);
   }
 #endif // _di_controller_rule_item_print_error_