From: Kevin Day <Kevin@kevux.org>
Date: Thu, 6 Mar 2025 02:05:03 +0000 (-0600)
Subject: Bugfix: The sources and under parameters can have invalid slashes.
X-Git-Url: https://git.kevux.org/?a=commitdiff_plain;h=d8c83ce7f7809dfa1ffef914c1dd56c567450a4a;p=fll

Bugfix: The sources and under parameters can have invalid slashes.

The directory path cleanup function is not being called for these due to an incorrect boolean value.

Rename `cleanups` to `directory` to make this more clear that this is about being a directory more so than it is about cleanups.

Fix out of date parameter type documentation comment.

Remove old todo comment.
---

diff --git a/level_3/fake/c/main/common.c b/level_3/fake/c/main/common.c
index 9220705..b322baf 100644
--- a/level_3/fake/c/main/common.c
+++ b/level_3/fake/c/main/common.c
@@ -184,7 +184,7 @@ extern "C" {
           fake_default_work_s,
         };
 
-        const bool cleanups[] = {
+        const uint8_t directory[] = {
           F_true,  // fake_parameter_build_e
           F_true,  // fake_parameter_data_e
           F_true,  // fake_parameter_documents_e
@@ -192,8 +192,8 @@ extern "C" {
           F_true,  // fake_parameter_licenses_e
           F_false, // fake_parameter_process_e
           F_false, // fake_parameter_settings_e
-          F_false, // fake_parameter_sources_e
-          F_false, // fake_parameter_under_e
+          F_true,  // fake_parameter_sources_e
+          F_true,  // fake_parameter_under_e
           F_true,  // fake_parameter_work_e
         };
 
@@ -218,8 +218,6 @@ extern "C" {
 
                   main->setting.state.status = f_utf_is_word_dash_plus(parameters->arguments.array[index].string + j, parameters->arguments.array[index].used - j, F_false);
 
-                  // @todo fix this to print an error about the actual invalid character so that it can be investigated.
-
                   if (F_status_is_error(main->setting.state.status)) {
                     if (fake_print_error_fallback(&main->program.error, macro_fake_f(f_utf_is_word_dash_plus)) == F_false) {
                       fll_program_print_error_parameter_process(&main->program.error, f_console_symbol_long_normal_s, names[i]);
@@ -238,7 +236,7 @@ extern "C" {
                 } // for
               }
 
-              if (cleanups[i]) {
+              if (directory[i]) {
                 main->setting.state.status = f_path_directory_cleanup(parameters->arguments.array[index], variable[i]);
 
                 if (F_status_is_error(main->setting.state.status)) {
diff --git a/level_3/fake/c/main/common/type.h b/level_3/fake/c/main/common/type.h
index 8368341..55d7f65 100644
--- a/level_3/fake/c/main/common/type.h
+++ b/level_3/fake/c/main/common/type.h
@@ -70,14 +70,16 @@ extern "C" {
  *   - flag:  Flags passed to the main function.
  *   - state: The state data used when processing the FSS data.
  *
- *   - build:    The build directory.
- *   - data:     The data directory.
- *   - fakefile: The fakefile file path.
- *   - process:  The process name.
- *   - settings: The settings file path.
- *   - sources:  The sources directory.
- *   - under:    The under directory.
- *   - work:     The work directory.
+ *   - build:     The build directory.
+ *   - data:      The data directory.
+ *   - documents: The documents directory.
+ *   - fakefile:  The fakefile file path.
+ *   - licenses:  The licenses directory.
+ *   - process:   The process name.
+ *   - settings:  The settings file path.
+ *   - sources:   The sources directory.
+ *   - under:     The under directory.
+ *   - work:      The work directory.
 
  *   - defines: The define data.
  *   - modes:   The mode data.