From: Kevin Day <Kevin@kevux.org>
Date: Thu, 11 Jul 2024 02:40:57 +0000 (-0500)
Subject: Bugfix: Improve Controller error message regarding "file not found..., found".
X-Git-Tag: 0.6.11~25
X-Git-Url: https://git.kevux.org/?a=commitdiff_plain;h=f198ea35e4fcc6d345925665388e87e170ef1d8f;p=fll

Bugfix: Improve Controller error message regarding "file not found..., found".

The error message essentially says file not found because file was found.
This is crazy confusing.

Fix the error message to say something more like unable to create the file because an existing file is found.
---

diff --git a/level_2/fll_error/c/error.c b/level_2/fll_error/c/error.c
index 61b877233..36ed4ccc9 100644
--- a/level_2/fll_error/c/error.c
+++ b/level_2/fll_error/c/error.c
@@ -232,7 +232,7 @@ extern "C" {
 
         fl_print_format("%r%[%QUnable to %Q %Q '%]", print.to.stream, f_string_eol_s, print.context, print.prefix, operation, type_name, print.context);
         fl_print_format("%[%Q%]", print.to.stream, print.notable, name, print.notable);
-        fl_print_format("%[', found.%]%r", print.to.stream, print.context, print.context, f_string_eol_s);
+        fl_print_format("%[', found existing %Q.%]%r", print.to.stream, print.context, print.context, type_name, f_string_eol_s);
 
         funlockfile(print.to.stream);
       }
diff --git a/level_3/controller/c/rule/private-rule.c b/level_3/controller/c/rule/private-rule.c
index 3ecc7f1ad..99d50b948 100644
--- a/level_3/controller/c/rule/private-rule.c
+++ b/level_3/controller/c/rule/private-rule.c
@@ -1662,7 +1662,7 @@ extern "C" {
     }
 
     if (status == F_true) {
-      controller_print_error_file(thread, main->error, F_file_found, "f_file_exists", F_true, pid_file, f_file_operation_find_s, fll_error_file_type_file_e);
+      controller_print_error_file(thread, main->error, F_file_found, "f_file_exists", F_true, pid_file, f_file_operation_create_s, fll_error_file_type_file_e);
 
       return F_status_set_error(F_file_found);
     }