Kevin Day [Wed, 23 Nov 2022 03:16:20 +0000 (21:16 -0600)]
Progress: Stub out the fss_write program.
The fss_write program is going to replace all of the other fss_X_write programs.
This is the initial setup and may not be the final structure.
I still have some fiddlign to do to figure out how I want them to share code.
The final result is intended to have the fss_write being capable of compiling all of the fss_X_write programs as well as the fss_write program.
Kevin Day [Wed, 23 Nov 2022 02:03:31 +0000 (20:03 -0600)]
Regression: Improper execution when no arguments and no pipe are passed to fake.
At some point in time the default for executing without a "clean", "make", or "build" stopped working.
This probably happened when I fixed the empty pipe bug.
Kevin Day [Wed, 23 Nov 2022 01:43:16 +0000 (19:43 -0600)]
Security: Invalid access when calling fake without 'make' or 'build'.
This is caused by the F_data_not return result not being processed in some of the fl_fss functions.
Additional changes:
- Make the return status constant.
- The status is being returned regardless in some cases so remove the effectively redundant lines of code.
- Combined the additional if condition blocks together.
Kevin Day [Tue, 22 Nov 2022 03:14:44 +0000 (21:14 -0600)]
Update: All projects should have fakefiles.
This is an oversight and neither a bug nor a feature.
The FLL is designed to be built using the build settings.
The flagship program fake, should still be directly supported and fakefiles should be available.
Most of these fakefiles just trigger the build settings.
Kevin Day [Thu, 17 Nov 2022 03:23:27 +0000 (21:23 -0600)]
Update: Finish program related work for fss_payload_write.
This appears to be done now.
The next step for fss_payload_write is to use it as the starting point for the fss_write program that is intended to provide all of the fss_*_write programs.
I will likely make improvements to the lazy approach I took regarding loading the entire file when processing.
I found two bugs regarding the pipe processing.
1) The first character never gets printed for payload Content.
2) An end-of-content character must be printed after the Content if printing partial Objects or if the "payload" Content is not yet printed.
Kevin Day [Fri, 11 Nov 2022 04:57:04 +0000 (22:57 -0600)]
Cleanup: Improve organization in f_utf, using addtional files.
Create more files to better organize structures and their accompanying functions.
Structures like f_utf_string_dynamic_t, f_utf_string_dynamics_t, and f_utf_string_dynamicss_t now each have their own files.
Kevin Day [Fri, 11 Nov 2022 03:25:05 +0000 (21:25 -0600)]
Cleanup: Improve organization in f_string, using addtional files.
Create more files to better organize structures and their accompanying functions.
Structures like f_string_dynamic_t, f_string_dynamics_t, and f_string_dynamicss_t now each have their own files.
Kevin Day [Tue, 8 Nov 2022 04:05:54 +0000 (22:05 -0600)]
Bugfix: Output stream is not properly unlocked on signal.
The output stream is locked during some loops.
When an appropriate signal is received while in one of these loops, the program exits.
The output stream must be unlocked before returning.
Kevin Day [Sun, 6 Nov 2022 22:03:36 +0000 (16:03 -0600)]
Feature: Add support for additional dependencies and settings files in level_3.
The package.sh build system helper script now supports additional dependencies and settings files.
This allows for special build modes, such as how the controller program has support for "controller" and "init" programs.
Kevin Day [Sat, 5 Nov 2022 01:24:38 +0000 (20:24 -0500)]
Bugfix: Incomplete UTF-8 zero-width detection, particularly for combining characters.
The zero-width calculations should be and are not including zero-width and most control characters.
The combining characters and most of the control characters are now considered zero-width.
Kevin Day [Sat, 29 Oct 2022 03:57:02 +0000 (22:57 -0500)]
Update: Slight improvement in UTF unassigned detection and add or correct some ranges.
Change "character" to "sequence" to be consistent with the rest of the private functions.
Add several additional checks to ideally reduce the number of checks.
This is only a cursory pass and not much effort is put into fine-tuned optimization.
There is huge room for improvement.
I discovered some ranges that needed to be added as unassined and added them.
Include the invalid ranges as unassigned.
Kevin Day [Sat, 29 Oct 2022 01:49:15 +0000 (20:49 -0500)]
Bugfix: Two 0's are printed when --total is used and there are no matching Objects.
There is an optimization used that immediately prints 0 and returns if there is no matching data on load.
The problem is that the caller isn't told that it should stop processing because F_none is returned.
Remove the optimization rather than implementing a custom return code and changing the code to handle this.
The normal code is still run and still correctly determines that there are 0 Objects.
Kevin Day [Fri, 28 Oct 2022 04:54:58 +0000 (23:54 -0500)]
Feature: Add support for ZSH in addition to BASH.
Some systems have started provided ZSH for license reasons (they don't want to agree to the license of BASH).
I experimented with and found that I can make my scripts ZSH friendly.
There is no way to "detect" that ZSH is being used as far as I can tell so I defined a new environment variable SHELL_ENGINE.
Set this to "zsh" and then run the script via the "zsh" program.
Enable emulation mode of "ksh" when using ZSH to be BASH friendly.
The ZSH doesn't support "${!i}" substitution.
I found a separate way to do this in ZSH via "${(P)i}".
It is a shame that they cannot simply replace "(P)" with "!".
There are several cases where "bash" is being directly called.
Replace this with a "shell_command" environment variable.
In some cases, directly calling "bash" may cause a loss of needed environment settings and so "bash" is not directly called when using BASH but "zsh" is still directly called when using ZSH.
The ZSH does not automatically handle arrays as well as BASH does.
Explicitly define arra with "-A" and explicitly set the initial value to "()".
Doing this may introduce problems with older versions of BASH that do not support "-A".
The ZSH cannot expand parameters as intelligently as BASH.
Parameters followed by certain characters, such as a bracket, that are not encases in braces result in ZSH errors.
Mass change many of the parameter uses to always be in braces.
Not all cases are changed and there may be some areas where I intended to make such a change and missed.
The ZSH appears not to handle output redirection from shell functions.
This behavior is used heavily in the project for building and using the variables array.
Change the behavior (at the cost of making the code a bit ugglier and harder to read in some cases) to assign a variable defined at a higher scope (such as "key").
The ZSH also appears to utilize "path" as a variable for "PATH" or is case insensitive when it comes to environment variables and shell variables.
This is a serious problem.
The variable "path" is defined so rename that to "path_" to avoid conflicts (and I'll just have to suffer cringing every time I see that trailing underscore).
I stumbled onto some bugs as well while making changes.
The necessary changes change the code that is buggy so I am allowing it to be in the same commit.
One of the bugs is a typo where errror is used rather than error.
Another bug is where the c_warning is used and then c_error is used within the same string (should be consistently using c_warning in this case).
It turns out "has-build_compiler" is not defined but conveniently a space for it is missing in bootstrap.sh (must be an accidental delete given the coincidence).
Some of the "mode" properties are incorrectly being assigned the non-mode value when a mode value exists in bootstrap.sh.
Kevin Day [Fri, 28 Oct 2022 01:07:00 +0000 (20:07 -0500)]
Cleanup: Rename and relocate private is_unassigned files.
The private-is_unassigned.c and private-is_unassigned.h are in incorrect locations and have incorrect names.
Relocate and rename to make these private files consistent with other private files.
Kevin Day [Fri, 28 Oct 2022 00:53:39 +0000 (19:53 -0500)]
Update: Support Unicode 15.0.
I couldn't easily find what Unicode version I am trying to suppot so I added a unicode.txt document.
The initial work was done for Unicode 12.1 and later switched to 14.0.
I was still in the initial stages of learning Unicode and so I expect there to be notable incompleteness or incorrectness.
With the release of Unicode 15.0 I am able to determine a distinct set of changes and I have applied the changes.
Add a private_inline_f_utf_character_handle_digit_offset() inline function to simplify some of the redundant code.
Kevin Day [Sun, 23 Oct 2022 21:31:53 +0000 (16:31 -0500)]
Progress: The iki_read should also support the previous "--substitute" behavior via "--reassign".
A "--substitute" bug is now fixed where the "--wrap" is applied.
It seems to me that the old behavior of "--substitute" should still exist.
Introduce a new parameter called "--reassign" that provides the old substitute behavior.
Kevin Day [Sun, 23 Oct 2022 02:58:16 +0000 (21:58 -0500)]
Progress: Fix problems in iki_read.
As I suspected, the interruptions resulted in incomplete and problematic code.
Fix copy and paste problems where modulus should instead be a slash (divide).
Use _increase_by functions rather than _resize functions to be more memory recycling friendly.
When processing parameters the index relative to the argv should be used.
Change the logic in the loops to increment "i" across all parameter values rather than the total sets.
Fix copy and paste mistakes where "wrap" is being incremented for non-wrap data.
The "--whole" parameter is not being processed and having the appropriate flag set.
The print function has incorrect ordering and structure of some of the functions called.
The print function is further simplified now that settings is passing the flag along.
The "wrap" append functions are not comparing against the correct variable (I swapped them by accident).
Do not do "register" types of optimizations at this point in time (this can be done far in the future when things are stable-ish).
Be sure to clear the lengths using memset().
The variable "k" can be moved inside the if condition following its assignment.
Kevin Day [Sat, 22 Oct 2022 14:50:44 +0000 (09:50 -0500)]
Refactor: Change FILE * to f_file_t when printing.
Due to the by-design restrictions, the f_file_t cannot be defined in f_file project and be used in another level_0 project.
The f_print project cannot depend on f_file project and cannot use f_file_t.
I spent some time considering this problem.
The f_type project is a special case core project that othe level_0 projects can depend on it.
This project also provides types and f_file_t is a type.
Move f_file_t's definition into f_file project.
I want to avoid always pulling in file related headers.
The the f_file_t is defined in a separate file "type_file.h".
The "type_file.h" must be manually included when needed.
With type_file.h in place, the print projects all include "type_file.h" and utilize f_file_t.
The "FILE *" stream is now replaced wth f_file_t.
This simplifies the code, makes it easier to use, and makes it easier to maintain.
For example, "fll_print_dynamic_raw(f_string_eol_s, main->output.to.stream);" can not be "fll_print_dynamic_raw(f_string_eol_s, main->output.to);".
I made this decision in the middle of a "Progress" change process.
There may be code missed and tests may need to be updated at some point after the "Progress" change process is complete.
Kevin Day [Fri, 21 Oct 2022 03:23:46 +0000 (22:23 -0500)]
Progress: Continue program related work.
There has been a lot of interruptions with this particular pass.
Additional review is recommended.
I specifically need to review the iki_read for all of the parameters and make sure that there are no regressions.
Simplify the code, replacing f_iki_content_t, f_iki_delimits_t, and similar with direct types such as f_string_ranges_t and f_array_lengths_t.
This reduces some of the flexibility but increases the maintainability.
Make some of the print error functions accepts the symbols for both the first and second parameters.
Add additional error print functions.
Fix problem with --help printing.
Comment consistency improvements.
The iki_read program is updated to follow the design changes regarding programs.
Kevin Day [Tue, 13 Sep 2022 01:00:11 +0000 (20:00 -0500)]
Progress: Continue program related work.
Add more common program print functions.
The parameter missing function is ironically missing the print messages.
I've decided to accept the loss of binary size for improved runtime efficiency (both of which are likely slight losses and improvements).
There are now "unlocked" and "locked" print line first and print line last functions for each program.
The boolean for designating lock is removed.
These functions are mostly wrappers and so the cost in size to be hopefully negligible.
I imagine time will tell whether this is an overall good or a bad decision.
Kevin Day [Mon, 5 Sep 2022 22:44:28 +0000 (17:44 -0500)]
Update: Add support for stand_alone builds in the example bootstrap script.
The bootstrap-example.sh script now supports building in "stand alone" mode for any program that has the mode defined.
The currently supported programs "fake" and "utf8" are still hard coded.
Future versions may check for the existence of the named files rather than being hard coded.
Update utf8 to compile.
Make the same changes for fake, but fake is not yet read because it has not been migrated yet.
I forgot to update the new "stand alone" build settings with the new private source file.
The tests now use this "stand alone" build for building fake and using that fake to perform the tests.
Fix a problem with existing code that has incorrect macros.
Kevin Day [Thu, 1 Sep 2022 02:19:05 +0000 (21:19 -0500)]
Progress: Continue program related work.
Slight restructuring of memory allocation:
- Add or move double free and and unnecessary free checks.
- If amount 0 for increase functions, then do nothing.
- When resizing, perform a stale check in case strings point to a static string.
- The private_f_memory_structure_resize() should properly return the error response.
The fll_program_standard_set_down() needs to check both the stream and the descriptors when closing rather than one or the other.
Explicitly set signal_received to uint32_t rather than int.
- The signal needs to also be uint32_t rather than f_status_t.
Add several new print functions for common print messages used by the programs.
Switch from flockfile() to f_file_stream_lock() and from funlockfile() to f_file_stream_unlock().
- There are still a lot more cases where these changes need to be made.
Add more function documentation.
Use "greater than" rather than "not equal to" for console verbosity checks.
More changes to these programs:
- fss_status_code
- iki_write
- status_code
- utf8
Kevin Day [Mon, 22 Aug 2022 02:22:38 +0000 (21:22 -0500)]
Progress: Working on program related changes and fix version number.
Continuing work in regards to making program related changes.
I managed to miss another set of files that have version numbers.
I should probably write a script to consistently handle this in the future to avoid these kinds of simple mistakes.
Change the behavior of the color loaded to allow for more flexibility.
The previous design was a quickly put togethor hardcoded approach.
I want to get away from such practices.
Add missing dependency in f_color.
I am at a cross roads of flexibility and maintainability (as well as size).
The practice of always having and using a typedef allows for great flexibility (allows for easy hacking/modifications).
As per my practice, I should have explicit functions for allocating, deallocating, and similar functions.
These waste space, consume time writing, and consume maintainance related time.
I want to increase the maintainability of the project given that my current goals are far reaching.
This means that I should switch to existing typedefs for any simple data type (except for special cases like strings and f_string_t).
I am starting this conversion with f_color, using the uintX_t types rathe than custom types like f_color_mode_t.
Start using enumerations over define macros.
Make the console parameter processing functions more flexible by returning the decision at the index rather than the converted decision value.
This allows for the caller to know which index is used.
The caller can do more work based on this without having to do more looping.
Add line_first_no and line_last_no standard parameters.
These add more flexibility for special case scripting.
Many core printing functions now do not print the leading new line.
All programs must be updated accordingly.
Add and document new console parameter initialization macros.
Start a new style practice with the console arguments, based around these new macros.
The f_file_stream_flush() should not need f_file_t parameter to be a pointer.
The memory functions now return F_data_not in more situations that make sense.
When size is 0 for allocation functions, this should be a paameter error when doing parameter checking.
The pointer should be allowed to be NULL when allocating.
Some fll_program functions are supposed to be using private functions due to internal usage.
The standard help options now have a standard printing function.
The fll_program_parameter_process() is removed.
Instead, call f_console_parameter_process directly.
The color context handling is moved from the now deleted fll_program_parameter_process() into fll_program_parameter_process_context().
The fll_program_data_t now accepts a pointer to the environment variable array for representing the environment variables are start.
The fll_program_data_t now uses flags rather than a boolean to represent program pipe (allowing for more than just input pipe, in theory).
Add new status codes:
- F_help
- F_help_not
Major work is completed into making the utf8 program more flexible.
- Moved all parameter processing into utf8_setting_load() and provide utf8_setting_t.
- This allows for callers to manually configure the settings without performing parameter processing if so desired.
- Re-design printing logic to handle the line_first_no and line_last_no parameters.
- The status used by the utf8_main() is now in utf8_setting_t.
Related changes have been lazily applied to all other programs.
Once I am finished with utf8 (which I might already be), then I will beging moving to each next program.
Kevin Day [Thu, 11 Aug 2022 04:06:20 +0000 (23:06 -0500)]
Progress: Begin breaking out internal parameters to allow for better caller control in programs.
Starting with utf8, start the process of breaking out the parameter settings into a variable that the caller can customize.
This should improve extensibility such that the caller can provide their own initializers.
Kevin Day [Thu, 11 Aug 2022 03:58:16 +0000 (22:58 -0500)]
Progress: Changes to fll_program functions.
Reduce needed arguments to fll_program_parameter_process().
The color loaded is now handled in fll_program_parameter_process().
Add fll_program_parameter_process_verbosity().
Rename fll_program_standard_setdown() to fll_program_standard_set_down() and accept fll_program_data_t rather than f_signal_t.
Rename fll_program_standard_setup() to fll_program_standard_set_up() and accept fll_program_data_t rather than f_signal_t.
The fll_program_standard_set_down() now handles closing all file descriptors, incliding standard ones.
Change "bool process_pipe" to "uint8_t pipe" in fll_program_data_t to allow for multiple bits to be used.
Add "fl_print_t message" and "fl_print_t debug" to fll_program_data_t to give caller more control over different possible buffers.
Kevin Day [Thu, 11 Aug 2022 03:50:26 +0000 (22:50 -0500)]
Update: Major changes regarding file functions.
I like having support for "standard" debug and "standard" warning.
The problem is that there is no such standard.
These are made available in case there ever is.
I want to simplify the code, so get rid of this non-standard "standard" code.
The low-level file functions inconsistently used id, stream, and file structure.
Switch everything to use the file structure.
Relax function errors by having invalid stream or invalid file descriptor return without error bit set.
In these cases use special status codes F_stream_not and F_file_descriptor_not as appropriate.
Simplify the functions to be simpler.
Some of the functions, namely the close functions, also support conditionally flushing before close.
Remove the flushing and the passed boolean.
Let the caller use two functions directly rather than building this in.
Add missing function for flushing via the file descriptor.
The private_f_file_flush() function is missing several disable macro checks.
(This change needs to be backported.)
This change does not address the tests.
This change does not address the programs that use or might use the changed, new, or deleted code.
Kevin Day [Mon, 8 Aug 2022 04:04:26 +0000 (23:04 -0500)]
Update: The utf8 program should be using the stream read functions.
The file is opened using the stream open functions.
It is silly and inconsistent to use the non stream functions to read from a file opened via a stream.
Kevin Day [Mon, 8 Aug 2022 04:00:46 +0000 (23:00 -0500)]
Bugfix: Functions private_f_file_flush() and private_f_print_safely_get() are not being inclided when needed.
The disable macro _di_f_file_stream_close_ is missing.
The disable macros _di_f_print_raw_safely_, _di_f_print_raw_safely_dynamic_, and _di_f_print_raw_safely_dynamic_partial_ are missing.
Kevin Day [Sun, 7 Aug 2022 02:00:58 +0000 (21:00 -0500)]
Bugfix: Stand alone build is pulling headers from system.
The projects headers should be pulled rather than system headers.
Restructure the stand alone package structure to match the installed headers structure.
This allows for leveraging the pre-compilers ability to locate the files.
Pass '-I sources/c' to the flags to properly locate the local headers rather than the system headers.
Kevin Day [Sun, 7 Aug 2022 01:02:20 +0000 (20:02 -0500)]
Update: The test script not uses stand alone mode for compiling Featureless Make.
The Featureless Make program that is compiled and used to run the tests is now done so using the stand alone mode.
This simplifies the process and avoids having any libraries in the path that could potentially be used (this has never happened, by the way).
Kevin Day [Sun, 7 Aug 2022 00:28:48 +0000 (19:28 -0500)]
Update: Implement stand alone build for Featureless Make.
This functions as both an example as well as a functional program.
I have not yet automated the disable macro process.
This process has been manually performed and may not remove all of the unnecessary code.
This does remove a vast majority of the unnecessary code.
Kevin Day [Sun, 7 Aug 2022 00:24:32 +0000 (19:24 -0500)]
Feature: Add support for 'stand_alone' builds in the package script.
Provide a way to compile programs, such as Featureless Make, with all of their dependencies and most (if not all) of the unnecessary dependencies not part of the programs.
These programs, such as the Featureless Make program, are compiled as a single program with no libfll.so (or program library such as libfake.so) built.
These are still compiled as either shared or static.
All non-FLL libraries in the shared programs are still linked as libraries.
This is a feature in the helper script and does not result in any API (or ABI) breakage.
Kevin Day [Sun, 7 Aug 2022 00:14:01 +0000 (19:14 -0500)]
Bugfix: Mistakes in disable macros and remove redundant check.
Fix numerous disable macro mistakes.
There are several functions that do not have the correct amount of disable macros.
There are several disable macros that have mistakes in the name structure.
The functions private_f_utf_string_append() and private_f_utf_string_append_nulless() are accidentally defined in the dynamic.h header file in addition to the string.h header file.
These should only be defined in one location and the ones defined in dynamic.h are incorrectly located.
Remove redundant errno check for ENOMEM in private_fl_directory_list().
Kevin Day [Fri, 5 Aug 2022 02:43:12 +0000 (21:43 -0500)]
Update: Change logic to avoid potential negative numbers.
Avoid using a subtraction.
Instead just use a comparison.
This should be more performant and also avoids potential negative numbers when dealing with unsigned numbers.
Kevin Day [Fri, 5 Aug 2022 02:33:42 +0000 (21:33 -0500)]
Update: Add missing structures to f_account_t and implement allocation functions.
I failed to notice that f_account is incomplete and this failed to make the 0.6 release window.
This is an API change and will only be applied to the 0.7 development releases as a result.
Provide real functions rather than macros for allocation and deallocation of the f_account_t structure.
Make sure both f_accounts_t and f_acountss_t exist for standard consistency.
Add unit tests.
Kevin Day [Tue, 2 Aug 2022 22:53:13 +0000 (17:53 -0500)]
Update: Redesign behavior of pipe, allowing it to run properly inside software like Gitlabs CI or Githubs CI.
I believe both of the CI systems (Github and Gitlab) use Docker.
These systems will place a new line in the input pipe before starting the programs being called.
This is bad behavior but I cannot do anything about it.
The previous design of Featureless Make is to use only the input pipe if it is specified.
This results in the Featureless Make operations to fail.
This redesigns the pipe handling behavior of Featurleess Make rather than try to submit a bug report to a team that is likely to completely ignore me.
The new behavior is as follows:
- If a pipe is specified, treat the pipe is prepended to the buffer that will be used for processing the file.
- This works for both "build" operations and "make" operations.
- The input pipe is treated as a "fakefile" when using the "make" operation.
- The input pipe is treated as a "settings" file when using the "build" operation.
- The input pipe may have an error bit so always clear the error.
- The "build" and "make" operations can be called within the "make" operation, recursively, so the pipe must only be processed by the outermost fakefile.
- The operation needs to be detected and identified as "default" to better determine how to handle missing files when a pipe is present and when a pipe is not present.
- Avoid resetting the buffer on every load so that the input pipe can be prepended without being reset.
Some of the code is cleaned up and simplified in regards to files.
Only perform the pre-process cleanup checks when there are more than two operations.
Kevin Day [Mon, 1 Aug 2022 03:54:48 +0000 (22:54 -0500)]
Update: Enable gitlab test support.
The gitlab can be designed to work the same as github.
Change the name of the relevant code from "github" to "ci" and have both gitlab and github modes call the ci functions.
For the time being using github as the source code repository is fine.
I should eventually clone the respective repos in gitlab and then conditionally use the URLs based off of the given build mode (github or gitlab).
Kevin Day [Sun, 31 Jul 2022 22:50:30 +0000 (17:50 -0500)]
Bugfix: Block is incorrectly being reset when an else condition precedes an if condition.
There is a logic mistake where the "else" is not being considered when determining when to reset the block.
This results in the block states being reset when the previous operation is an "else" condition.
This results in the second else condition potentially running even if the prior condition already ran.
This was discovered when investigating Github actions test failures that pass locally.
The Github actions tests use a special test argument that I had not tested locally with.
Kevin Day [Sat, 30 Jul 2022 00:22:10 +0000 (19:22 -0500)]
Bugfix: private_f_file_open_at() has an incomplete set if ifdef conditions.
The ifdef conditions for disabled functions is incomplete.
This results in the private_f_file_open_at() becoming incorrectly unavailable when the appropriate disable defines are set.
Kevin Day [Thu, 28 Jul 2022 00:36:31 +0000 (19:36 -0500)]
Update: Improve specification files.
Expand the vocabulary to include more words such as "character".
This allows for more granular control over substitution.
This is a must to easily convert to both plain text and HTML from the same source file.
Kevin Day [Thu, 28 Jul 2022 00:09:16 +0000 (19:09 -0500)]
Update: Clarify IKI standard in regards to delimits and improve specification file.
Add additional commands to the specification iki_read example.
Expand the vocabulary to include more words such as "character".
This allows for more granular control over substitution.
This is a must to easily convert to both plain text and HTML from the same source file.
Fix incorrect example where the delimits are on the wrong characters (url:\' is not correct and instead should be url\;').
Add delimits to accidentally undelimited code.
These changes exposed a mistake in both the processing code and a detail on how I explained the specification.
The IKI processing only needs a delimit when the vocabulary name followed by a colon followed by either a single or a double quote.
That is to say, the matching closing single or double quote is irrelevant.
This simplifies the logic needed to both read and write the IKI content for both machines and humans.
Note that this is in contrast to how the FSS works.
IKI is designed for different purposes than FSS and thus has slightly different design paradigms.
The code processing this is incorrectly failing to apply delimits for any potentially valid IKI content inside an already valid but delimited IKI variable.
Fixing this conveniently also results in simpler code and fewer variables used (saving trivial memory).
Kevin Day [Sun, 24 Jul 2022 03:26:25 +0000 (22:26 -0500)]
Update: Add +E/++error parameter to firewall.
The previous security commit 7348813d0af17acda440eb66c038f6bdd07c1a6e is the result of an incomplete addition of the +E/++error parameter.
The size of the total parameters was incremented to ensure space for the +E/++error but the +E/++error was never added.
This increments the total parameters and adds the +E/++error row.
Kevin Day [Sat, 23 Jul 2022 22:41:30 +0000 (17:41 -0500)]
Bugfix: Link operation is incorrect, support new link arguments, and clone and copy operation failure problems.
The link operation target path is relative to the point path.
The previous code is trying to treat the target path in isolation.
Change the behavior to make the target path relative to the point path.
Add two new options to make creating symbolic linking easier to use:
1) "force": Used to forcibly overwrite an existing file or directory.
2) "strict": Used to require the target path to exist when creating the symbolic links.
The clone and copy operations now have better error return code processing.
The operate process type operations are not all in their own functions.
Change the code to move all of the operate process type operations into their own functions.
Kevin Day [Sat, 23 Jul 2022 15:55:55 +0000 (10:55 -0500)]
Update: Organize the validate operation into separate type functions and improve error handling logic.
Move the contents of each validate operation if condition block into separate functions.
This makes the validate operation code more consistent with how the process operation code.
This simplifies some of the nesting.
This has a cost of adding and calling more functions.
Multi-purpose functions are used where applicable rather than having a single function for each operation type.
The error handling is improved in some cases where errors are printed for all arguments rather than the first.
This is done only in cases where I could obviously and quickly determine that this can be done.
There is the possibility of mistakes or regressions due to the structural changes and the condition block changes.