From 08791c72e640cfe426f218a8690d783b57c64351 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Mon, 16 Jan 2023 15:19:35 -0600 Subject: [PATCH] Cleanup: Use 0 instead of F_false in firewall initialization. Mathematically, the F_false and 0 are synonymous. Semantically, the F_false represents a boolean and 0 represents a digit. Using F_false here has incorrect semantic meaning. --- level_3/firewall/c/common.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/level_3/firewall/c/common.h b/level_3/firewall/c/common.h index 57dc762..708e1fe 100644 --- a/level_3/firewall/c/common.h +++ b/level_3/firewall/c/common.h @@ -394,11 +394,11 @@ extern "C" { macro_f_console_parameter_t_initialize(f_console_standard_short_verbose_s.string, f_console_standard_long_verbose_s.string, 0, 0, f_console_type_inverse_e), \ macro_f_console_parameter_t_initialize(f_console_standard_short_debug_s.string, f_console_standard_long_debug_s.string, 0, 0, f_console_type_inverse_e), \ macro_f_console_parameter_t_initialize(f_console_standard_short_version_s.string, f_console_standard_long_version_s.string, 0, 0, f_console_type_inverse_e), \ - macro_f_console_parameter_t_initialize(0, 0, firewall_command_start_s.string, F_false, f_console_type_other_e), \ - macro_f_console_parameter_t_initialize(0, 0, firewall_command_stop_s.string, F_false, f_console_type_other_e), \ - macro_f_console_parameter_t_initialize(0, 0, firewall_command_restart_s.string, F_false, f_console_type_other_e), \ - macro_f_console_parameter_t_initialize(0, 0, firewall_command_lock_s.string, F_false, f_console_type_other_e), \ - macro_f_console_parameter_t_initialize(0, 0, firewall_command_show_s.string, F_false, f_console_type_other_e), \ + macro_f_console_parameter_t_initialize(0, 0, firewall_command_start_s.string, 0, f_console_type_other_e), \ + macro_f_console_parameter_t_initialize(0, 0, firewall_command_stop_s.string, 0, f_console_type_other_e), \ + macro_f_console_parameter_t_initialize(0, 0, firewall_command_restart_s.string, 0, f_console_type_other_e), \ + macro_f_console_parameter_t_initialize(0, 0, firewall_command_lock_s.string, 0, f_console_type_other_e), \ + macro_f_console_parameter_t_initialize(0, 0, firewall_command_show_s.string, 0, f_console_type_other_e), \ } #define firewall_total_parameters_d 15 -- 1.8.3.1