From 14cbf34f92a4f8c31a46a9dc59ba48e11036c620 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Tue, 29 Mar 2022 22:54:34 -0500 Subject: [PATCH] Update: Move the program data into the main for fss_payload_write. Move parameter initialization and deallocation for FLL program data into main.c. --- level_3/fss_payload_write/c/common.c | 7 ------- level_3/fss_payload_write/c/common.h | 19 ------------------- level_3/fss_payload_write/c/fss_payload_write.c | 17 ++--------------- level_3/fss_payload_write/c/fss_payload_write.h | 4 ---- level_3/fss_payload_write/c/main.c | 6 ++++++ 5 files changed, 8 insertions(+), 45 deletions(-) diff --git a/level_3/fss_payload_write/c/common.c b/level_3/fss_payload_write/c/common.c index 50e369a..6d321da 100644 --- a/level_3/fss_payload_write/c/common.c +++ b/level_3/fss_payload_write/c/common.c @@ -32,13 +32,6 @@ extern "C" { const f_string_static_t fss_payload_write_long_trim_s = macro_f_string_static_t_initialize(FSS_PAYLOAD_WRITE_long_trim_s, 0, FSS_PAYLOAD_WRITE_long_trim_s_length); #endif // _di_fss_payload_write_parameters_ -#ifndef _di_fss_payload_write_main_delete_ - f_status_t fss_payload_write_main_delete(fll_program_data_t * const main) { - - return fll_program_data_delete(main); - } -#endif // _di_fss_payload_write_main_delete_ - #ifdef __cplusplus } // extern "C" #endif diff --git a/level_3/fss_payload_write/c/common.h b/level_3/fss_payload_write/c/common.h index bebe0ac..68c7551 100644 --- a/level_3/fss_payload_write/c/common.h +++ b/level_3/fss_payload_write/c/common.h @@ -189,25 +189,6 @@ extern "C" { #define fss_payload_write_total_parameters_d 18 #endif // _di_fss_payload_write_parameters_ -/** - * Deallocate main. - * - * Be sure to call this after executing fss_payload_write_main(). - * - * @param main - * The main program data. - * - * @return - * F_none on success. - * - * Status codes (with error bit) are returned on any problem. - * - * @see fss_payload_write_main() - */ -#ifndef _di_fss_payload_write_main_delete_ - extern f_status_t fss_payload_write_main_delete(fll_program_data_t * const main); -#endif // _di_fss_payload_write_main_delete_ - #ifdef __cplusplus } // extern "C" #endif diff --git a/level_3/fss_payload_write/c/fss_payload_write.c b/level_3/fss_payload_write/c/fss_payload_write.c index d35c01c..1854114 100644 --- a/level_3/fss_payload_write/c/fss_payload_write.c +++ b/level_3/fss_payload_write/c/fss_payload_write.c @@ -70,10 +70,6 @@ extern "C" { f_status_t status = F_none; - f_console_parameter_t parameters[] = fss_payload_write_console_parameter_t_initialize; - main->parameters.array = parameters; - main->parameters.used = fss_payload_write_total_parameters_d; - { f_console_parameter_id_t ids[3] = { fss_payload_write_parameter_no_color_e, fss_payload_write_parameter_light_e, fss_payload_write_parameter_dark_e }; const f_console_parameter_ids_t choices = macro_f_console_parameter_ids_t_initialize(ids, 3); @@ -100,10 +96,7 @@ extern "C" { fll_program_parameter_process_empty(&main->context, sets); } - if (F_status_is_error(status)) { - fss_payload_write_main_delete(main); - return F_status_set_error(status); - } + if (F_status_is_error(status)) return F_status_set_error(status); } // Identify priority of verbosity related parameters. @@ -114,10 +107,7 @@ extern "C" { status = f_console_parameter_prioritize_right(main->parameters, choices, &choice); - if (F_status_is_error(status)) { - fss_payload_write_main_delete(main); - return status; - } + if (F_status_is_error(status)) return status; if (choice == fss_payload_write_parameter_verbosity_quiet_e) { main->output.verbosity = f_console_verbosity_quiet_e; @@ -148,14 +138,12 @@ extern "C" { if (main->parameters.array[fss_payload_write_parameter_help_e].result == f_console_result_found_e) { fss_payload_write_print_help(main->output.to, main->context); - fss_payload_write_main_delete(main); return status; } if (main->parameters.array[fss_payload_write_parameter_version_e].result == f_console_result_found_e) { fll_program_print_version(main->output.to, fss_payload_write_program_version_s); - fss_payload_write_main_delete(main); return status; } @@ -517,7 +505,6 @@ extern "C" { } f_string_dynamic_resize(0, &buffer); - fss_payload_write_main_delete(main); return status; } diff --git a/level_3/fss_payload_write/c/fss_payload_write.h b/level_3/fss_payload_write/c/fss_payload_write.h index 1679a62..c0b2a27 100644 --- a/level_3/fss_payload_write/c/fss_payload_write.h +++ b/level_3/fss_payload_write/c/fss_payload_write.h @@ -65,8 +65,6 @@ extern "C" { /** * Execute main program. * - * Be sure to call fss_payload_write_main_delete() after executing this. - * * If main.signal is non-zero, then this blocks and handles the following signals: * - F_signal_abort * - F_signal_broken_pipe @@ -84,8 +82,6 @@ extern "C" { * F_none on success. * * Status codes (with error bit) are returned on any problem. - * - * @see fss_payload_write_main_delete() */ #ifndef _di_fss_payload_write_main_ extern f_status_t fss_payload_write_main(fll_program_data_t * const main, const f_console_arguments_t *arguments); diff --git a/level_3/fss_payload_write/c/main.c b/level_3/fss_payload_write/c/main.c index 6271b61..cbb903c 100644 --- a/level_3/fss_payload_write/c/main.c +++ b/level_3/fss_payload_write/c/main.c @@ -5,6 +5,10 @@ int main(const int argc, const f_string_t *argv, const f_string_t *envp) { const f_console_arguments_t arguments = macro_f_console_arguments_t_initialize(argc, argv, envp); fll_program_data_t data = fll_program_data_t_initialize; + f_console_parameter_t parameters[] = fss_payload_write_console_parameter_t_initialize; + data.parameters.array = parameters; + data.parameters.used = fss_payload_write_total_parameters_d; + if (f_pipe_input_exists()) { data.process_pipe = F_true; } @@ -13,6 +17,8 @@ int main(const int argc, const f_string_t *argv, const f_string_t *envp) { const f_status_t status = fss_payload_write_main(&data, &arguments); + fll_program_data_delete(&data); + fll_program_standard_setdown(&data.signal); if (F_status_is_error(status)) return 1; -- 1.8.3.1