From 296f63b5ab1a3fa87aa66f8fb9978b6775dc18b4 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Sat, 5 Aug 2023 15:57:14 -0500 Subject: [PATCH] Update: Add comment in Featureless Make code to designate changes the must be done. The use of main->program.parameters.arguments should no longer happen. This is the old behavior and it looks like it has not been completely migrated. This is wrong an can even have invalid read sizes. --- level_3/fake/c/main/fake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/level_3/fake/c/main/fake.c b/level_3/fake/c/main/fake.c index 9374ace..7cd4659 100644 --- a/level_3/fake/c/main/fake.c +++ b/level_3/fake/c/main/fake.c @@ -456,6 +456,7 @@ extern "C" { if (parameter->result & f_console_result_value_e) { const f_number_unsigned_t index = parameter->values.array[parameter->location]; + // @fixme these should not be accessing main->program.parameters.arguments directly and should instead use setting flags. if (f_path_is_absolute(main->program.parameters.arguments.array[index]) == F_true || f_path_is_relative_current(main->program.parameters.arguments.array[index]) == F_true) { requireds[1] = F_none; // fake_long_data_s } -- 1.8.3.1