From c9436c925a23b0ce37b148ac03f60c5332bfb26e Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Wed, 6 Sep 2023 00:45:46 -0500 Subject: [PATCH] Bugfix: Problems exposed by clang-13. The Vedic Extensions Unicode checks are out of order. Remove unused "last" variable from private_fl_utf_file_write_until(). Add missing "return" keyword in Featureless Make. --- level_0/f_utf/c/private-utf_combining.c | 8 ++++---- level_1/fl_utf_file/c/private-utf_file.c | 2 -- level_3/fake/c/private-build-skeleton.c | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/level_0/f_utf/c/private-utf_combining.c b/level_0/f_utf/c/private-utf_combining.c index f851bc5..d919041 100644 --- a/level_0/f_utf/c/private-utf_combining.c +++ b/level_0/f_utf/c/private-utf_combining.c @@ -668,8 +668,8 @@ extern "C" { return F_true; } - // Vedic Extensions: U+1CD4 to U+1CD2. - if (sequence >= 0xe1b39400 && sequence <= 0xe1b39200) { + // Vedic Extensions: U+1CD2 to U+1CD4. + if (sequence >= 0xe1b39200 && sequence <= 0xe1b39400) { return F_true; } @@ -688,8 +688,8 @@ extern "C" { return F_true; } - // Vedic Extensions: U+1DC0 to U+1CE8. - if (sequence >= 0xe1b78000 && sequence <= 0xe1b3a800) { + // Vedic Extensions: U+1CE8 to U+1DC0. + if (sequence >= 0xe1b3a800 && sequence <= 0xe1b78000) { return F_true; } diff --git a/level_1/fl_utf_file/c/private-utf_file.c b/level_1/fl_utf_file/c/private-utf_file.c index 6ca3592..6e05098 100644 --- a/level_1/fl_utf_file/c/private-utf_file.c +++ b/level_1/fl_utf_file/c/private-utf_file.c @@ -82,7 +82,6 @@ extern "C" { write_size = write_max; } - f_array_length_t last = 0; f_array_length_t used = 0; ssize_t size_write = 0; @@ -179,7 +178,6 @@ extern "C" { } *written += i; - last += used; if (*written + write_size > write_max) { write_size = write_max - *written; diff --git a/level_3/fake/c/private-build-skeleton.c b/level_3/fake/c/private-build-skeleton.c index 524ba6a..0bddef4 100644 --- a/level_3/fake/c/private-build-skeleton.c +++ b/level_3/fake/c/private-build-skeleton.c @@ -12,7 +12,7 @@ extern "C" { void fake_build_skeleton(fake_data_t * const data, fake_build_data_t * const data_build, const mode_t mode, const f_string_static_t file_stage, f_status_t * const status) { if (*status == F_child) return; - if (F_status_is_error(*status) || f_file_exists(file_stage, F_true) == F_true); + if (F_status_is_error(*status) || f_file_exists(file_stage, F_true) == F_true) return; f_string_static_t path_headers = f_string_static_t_initialize; path_headers.used = data->path_build_includes.used + data_build->setting.path_headers.used; -- 1.8.3.1