From ee262771516920c13681512631aac3899549ad40 Mon Sep 17 00:00:00 2001
From: Kevin Day <thekevinday@gmail.com>
Date: Thu, 25 Jul 2019 20:49:29 -0500
Subject: [PATCH] Bugfix: bash/linux does not support setting high bits on
 return codes

These bits are generally reserved for process-specific behavior.
Explicitly return 0 for success and 1 for failure.
The firewall program already does this.

The return codes from the main functions of each project will continue to utilize all of the bits as designed.
This will allow for projects that link to the library to get the actual return codes while simultaneously being compatible with Linux and Bash.

Later versions may provide alternative ways to get the error code from within the shell.
For example, if a specific return code environment variable is set, then the program could populate that environment variable on exit (clearing it on start).
---
 level_3/fss_basic_list_read/c/main.c  | 6 +++++-
 level_3/fss_basic_list_write/c/main.c | 6 +++++-
 level_3/fss_basic_read/c/main.c       | 6 +++++-
 level_3/fss_basic_write/c/main.c      | 6 +++++-
 level_3/fss_extended_read/c/main.c    | 6 +++++-
 level_3/fss_extended_write/c/main.c   | 6 +++++-
 level_3/fss_return_code/c/main.c      | 6 +++++-
 level_3/return_code/c/main.c          | 6 +++++-
 8 files changed, 40 insertions(+), 8 deletions(-)

diff --git a/level_3/fss_basic_list_read/c/main.c b/level_3/fss_basic_list_read/c/main.c
index 0cd7ee344..5f5130fce 100644
--- a/level_3/fss_basic_list_read/c/main.c
+++ b/level_3/fss_basic_list_read/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_basic_list_read_main(argc, argv, &data);
+  if (f_error_is_error(fss_basic_list_read_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_basic_list_write/c/main.c b/level_3/fss_basic_list_write/c/main.c
index feaa3e99b..5132d141e 100644
--- a/level_3/fss_basic_list_write/c/main.c
+++ b/level_3/fss_basic_list_write/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_basic_list_write_main(argc, argv, &data);
+  if (f_error_is_error(fss_basic_list_write_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_basic_read/c/main.c b/level_3/fss_basic_read/c/main.c
index 1c27146ad..a8826cd74 100644
--- a/level_3/fss_basic_read/c/main.c
+++ b/level_3/fss_basic_read/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_basic_read_main(argc, argv, &data);
+  if (f_error_is_error(fss_basic_read_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_basic_write/c/main.c b/level_3/fss_basic_write/c/main.c
index af17f394d..3af35be69 100644
--- a/level_3/fss_basic_write/c/main.c
+++ b/level_3/fss_basic_write/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_basic_write_main(argc, argv, &data);
+  if (f_error_is_error(fss_basic_write_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_extended_read/c/main.c b/level_3/fss_extended_read/c/main.c
index b79163a7f..ee3ed3994 100644
--- a/level_3/fss_extended_read/c/main.c
+++ b/level_3/fss_extended_read/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_extended_read_main(argc, argv, &data);
+  if (f_error_is_error(fss_extended_read_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_extended_write/c/main.c b/level_3/fss_extended_write/c/main.c
index ceacde71e..969fc3ca2 100644
--- a/level_3/fss_extended_write/c/main.c
+++ b/level_3/fss_extended_write/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_extended_write_main(argc, argv, &data);
+  if (f_error_is_error(fss_extended_write_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/fss_return_code/c/main.c b/level_3/fss_return_code/c/main.c
index fe72b7db3..904588967 100644
--- a/level_3/fss_return_code/c/main.c
+++ b/level_3/fss_return_code/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return fss_return_code_main(argc, argv, &data);
+  if (f_error_is_error(fss_return_code_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
diff --git a/level_3/return_code/c/main.c b/level_3/return_code/c/main.c
index facd2617d..639ef6129 100644
--- a/level_3/return_code/c/main.c
+++ b/level_3/return_code/c/main.c
@@ -7,5 +7,9 @@ int main(f_const f_array_length argc, f_const f_string argv[]) {
     data.process_pipe = f_true;
   }
 
-  return return_code_main(argc, argv, &data);
+  if (f_error_is_error(return_code_main(argc, argv, &data))) {
+    return 1;
+  }
+
+  return 0;
 }
-- 
2.47.3